Opened 16 months ago

Last modified 2 weeks ago

#939 in_review defect

Strong Tags broken in generic case

Reported by: adeiana Owned by: simko
Priority: minor Milestone: v1.2
Component: BibUpload Version: maint-1.0
Keywords: CFG_BIBUPLOAD_STRONG_TAGS Cc: alessio.deiana@…

Description

I am trying to use CFG_BIBUPLOAD_STRONG_TAGS for the tag 999

However copy_strong_tags_from_old_record is checking for fields with
record_get_field_instances(rec_old, strong_tag)
In my case this never gets any result because references have subfields set.
I would replace it with
record_get_field_instances(rec_old, strong_tag, '%', '%')

Attachments (1)

0001-BibUpload-indicators-in-strong-tags.patch (1.4 KB) - added by skaplun 4 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 16 months ago by adeiana

  • Cc alessio.deiana@… added

comment:2 Changed 14 months ago by skaplun

  • Owner set to skaplun
  • Status changed from new to assigned

comment:3 Changed 14 months ago by skaplun

Indeed we should take care of correctly handling the presence or absence of ind1 and ind2 in the tag specified by CFG_BIBUPLOAD_STRONG_TAGS.

comment:4 Changed 5 months ago by skaplun

  • Milestone set to v1.2

comment:5 Changed 4 months ago by skaplun

  • Keywords CFG_BIBUPLOAD_STRONG_TAGS added
  • Status changed from assigned to in_merge
  • Version set to maint-1.0

The attached patch implement the proposal for maint-1.0 on-wards.

comment:6 Changed 2 weeks ago by simko

  • Owner changed from skaplun to simko
  • Status changed from in_merge to in_review
Note: See TracTickets for help on using tickets.