Opened 2 years ago

Closed 8 months ago

Last modified 8 months ago

#939 closed defect (fixed)

Strong Tags broken in generic case

Reported by: adeiana Owned by: simko
Priority: minor Milestone: v1.2
Component: BibUpload Version: maint-1.0
Keywords: CFG_BIBUPLOAD_STRONG_TAGS Cc: alessio.deiana@…

Description

I am trying to use CFG_BIBUPLOAD_STRONG_TAGS for the tag 999

However copy_strong_tags_from_old_record is checking for fields with
record_get_field_instances(rec_old, strong_tag)
In my case this never gets any result because references have subfields set.
I would replace it with
record_get_field_instances(rec_old, strong_tag, '%', '%')

Attachments (1)

0001-BibUpload-indicators-in-strong-tags.patch (1.4 KB) - added by skaplun 15 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 2 years ago by adeiana

  • Cc alessio.deiana@… added

comment:2 Changed 2 years ago by skaplun

  • Owner set to skaplun
  • Status changed from new to assigned

comment:3 Changed 2 years ago by skaplun

Indeed we should take care of correctly handling the presence or absence of ind1 and ind2 in the tag specified by CFG_BIBUPLOAD_STRONG_TAGS.

comment:4 Changed 15 months ago by skaplun

  • Milestone set to v1.2

comment:5 Changed 15 months ago by skaplun

  • Keywords CFG_BIBUPLOAD_STRONG_TAGS added
  • Status changed from assigned to in_merge
  • Version set to maint-1.0

The attached patch implement the proposal for maint-1.0 on-wards.

comment:6 Changed 11 months ago by simko

  • Owner changed from skaplun to simko
  • Status changed from in_merge to in_review

comment:7 Changed 8 months ago by skaplun

  • Resolution set to fixed
  • Status changed from in_review to closed

In 6999ab19979bb50a7931bb1242f3f5671fe697e8/invenio:

BibUpload: indicators in strong tags

  • So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong tags had empty indicator. This was causing tags such as 999C0 to never be matched. The new implementation assume strong tags specify also indicators. If they are not specified, then '%' is ussumed for ind1 and ind2. (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@…>
Reviewed-by: Tibor Simko <tibor.simko@…>

comment:8 Changed 8 months ago by skaplun

In 6999ab19979bb50a7931bb1242f3f5671fe697e8/invenio:

BibUpload: indicators in strong tags

  • So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong tags had empty indicator. This was causing tags such as 999C0 to never be matched. The new implementation assume strong tags specify also indicators. If they are not specified, then '%' is ussumed for ind1 and ind2. (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@…>
Reviewed-by: Tibor Simko <tibor.simko@…>

comment:9 Changed 8 months ago by skaplun

In 6999ab19979bb50a7931bb1242f3f5671fe697e8/invenio:

BibUpload: indicators in strong tags

  • So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong tags had empty indicator. This was causing tags such as 999C0 to never be matched. The new implementation assume strong tags specify also indicators. If they are not specified, then '%' is ussumed for ind1 and ind2. (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@…>
Reviewed-by: Tibor Simko <tibor.simko@…>

comment:10 Changed 8 months ago by skaplun

In 6999ab19979bb50a7931bb1242f3f5671fe697e8/invenio:

BibUpload: indicators in strong tags

  • So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong tags had empty indicator. This was causing tags such as 999C0 to never be matched. The new implementation assume strong tags specify also indicators. If they are not specified, then '%' is ussumed for ind1 and ind2. (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@…>
Reviewed-by: Tibor Simko <tibor.simko@…>

Note: See TracTickets for help on using tickets.