Opened 3 years ago

Closed 14 months ago

Last modified 14 months ago

#546 closed defect (fixed)

WebStat: renaming a column in webstat.cfg deletes the column

Reported by: jcaffaro Owned by: calvarez
Priority: trivial Milestone: v1.2
Component: WebStat Version:
Keywords: Cc:

Description

When renaming a column in webstat.cfg and running ./webstatadmin --load-config,
the column is deleted from the database instead of being renamed, losing the information previously logged.

It would be safer that the column is renamed instead of being "replaced".

Change History (13)

comment:1 Changed 3 years ago by calvarez

  • Status changed from new to in_merge

comment:2 Changed 3 years ago by simko

  • Status changed from in_merge to assigned

This commit builds on top of another commit that has issues like
909C4p being replaced by 773__p. The demo markup uses 909C4p
precisely so that things like this are configurable... The correct
field to use is 909C4 for the demo markup, while 773 for CDS markup.
So we cannot do such a change globally, it must be made configurable.
More comments IRL.

comment:3 Changed 3 years ago by calvarez

  • Status changed from assigned to in_merge

comment:4 Changed 2 years ago by Carmen Alvarez Perez <carmen.alvarez.perez@…>

  • Resolution set to fixed
  • Status changed from in_merge to closed

In [5cfe726a1e0676dfd858198bec589fe7cddae541]:

WebStat: minor improvements

  • When renaming a column in webstat.cfg and running ./webstatadmin --load-config, the column was deleted from the database. Now, the user is asked if he wants to delete it or rename it (fixes #546)
  • Change line graphs to bar graphs
  • Add average, max and min values for events
  • Fix total records count now also counts restricted collections
  • Clean up code
  • Improve display of data when selecting last 2, 5 or 10 years
  • Change names of bibcirculation stats

comment:5 follow-up: Changed 2 years ago by simko

  • Resolution fixed deleted
  • Status changed from closed to new

Reopening this ticket, because the above comment:2 related to 909C4 vs 773 was not addressed... slipped during merge.

comment:6 Changed 2 years ago by simko

  • Status changed from new to assigned

comment:7 in reply to: ↑ 5 ; follow-up: Changed 2 years ago by calvarez

  • Status changed from assigned to in_merge

Replying to simko:

Reopening this ticket, because the above comment:2 related to 909C4 vs 773 was not addressed... slipped during merge.

It was fixed in this commit: http://invenio-software.org/repo/invenio/commit/?id=ea5536211192ac35b81615a73a8d8acdb7611b7f

  • Fix custom query summary (use CFG_JOURNAL_TAG variable)

comment:8 in reply to: ↑ 7 Changed 2 years ago by simko

  • Status changed from in_merge to assigned

Replying to calvarez:

It was fixed in this commit:

Actually, it wasn't fixed in that commit. The commit you mention was merged back in November as [ea5536211192ac35b81615a73a8d8acdb7611b7f] already, and while it addresses the 773/909C4 issue, it does not fixes it completely. Which is why I reopened this ticket.

$ git grep -C 1 773 modules/webstat/lib/
modules/webstat/lib/webstat.py-    if args['tag'] == '':
modules/webstat/lib/webstat.py:        args['tag'] = "773__p"
modules/webstat/lib/webstat.py-    data = get_custom_summary_data(args['query'], args['tag'])

comment:10 Changed 15 months ago by skaplun

  • Milestone set to v1.2

comment:11 Changed 14 months ago by Carmen Alvarez Perez <carmen.alvarez.perez@…>

  • Resolution set to fixed
  • Status changed from in_merge to closed

In 337bcc726b3b6d6801edf49582911ad09fe082b8/invenio:

WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

  • Uses configurable journal tag (CFG_JOURNAL_TAG) instead of hard-coded 773/909C4. (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@…>

comment:12 Changed 14 months ago by Carmen Alvarez Perez <carmen.alvarez.perez@…>

In 337bcc726b3b6d6801edf49582911ad09fe082b8/invenio:

WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

  • Uses configurable journal tag (CFG_JOURNAL_TAG) instead of hard-coded 773/909C4. (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@…>

comment:13 Changed 14 months ago by Carmen Alvarez Perez <carmen.alvarez.perez@…>

In 337bcc726b3b6d6801edf49582911ad09fe082b8/invenio:

WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

  • Uses configurable journal tag (CFG_JOURNAL_TAG) instead of hard-coded 773/909C4. (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@…>

Note: See TracTickets for help on using tickets.