Opened 3 years ago

Closed 3 years ago

#323 closed defect (fixed)

websearch: fin cn cms and date 2010 and t dog

Reported by: jblayloc Owned by: jblayloc
Priority: major Milestone:
Component: WebSearch Version:
Keywords: INSPIRE Syntax Cc:

Description

On ß release we had a bug in date parsing for the above string, because the regexps were matching the date term as
year:2010 and title:dog
rather than
year:2010

For the sake of rollout, we fixed it by catching exceptions thrown by dateutil and simply using the user's input date string instead.

This is a ticket to go back and correct the regex so it never gets too much stuff.

Change History (2)

comment:1 Changed 3 years ago by jblayloc

  • Status changed from new to in_merge

This is complete in my branch 323-websearch_date_regexps_problematic; all of the unit tests pass (including the new ones) and the regression tests are no worse than they were.

comment:2 Changed 3 years ago by Joe Blaylock <jrbl@…>

  • Resolution set to fixed
  • Status changed from in_merge to closed

In [dc864c5b8c2205b3e43e14fb87beadc5743e5411]:

WebSearch: SPIRES syntax date robustness fix

  • Less buggy regular expression for matching dates in SPIRES syntax converter, and additional unit tests. (fixes #323)
Note: See TracTickets for help on using tickets.