Opened 2 years ago

Last modified 11 months ago

#1023 in_review defect

BatchUploader: allow insertion of text MARC

Reported by: jcaffaro Owned by: simko
Priority: trivial Milestone:
Component: BibEdit Version:
Keywords: BatchUploader Cc: Jocelyne.Jerdelet@…

Description

Batchuploader interface allows to "--insert" "TextMarc" records, but the underlying textmarc2xmlmarc.py will not support the creation of MARCXML without a record ID (tag 001), which is necessary to avoid when inserting records (and not updating/replacing).

  • The textmarc2xmlmarc.py could be enhanced to support input MARC without recid (a fake prefixing recid would still be needed in the input to differentiate records)
  • batchuploader_engine.py could strip off the recid created by textmarc2xmlmarc.py if it is run in "--insert" mode
  • The "--insert" option could be removed from web interface when "TextMARC" record is selected (and "TextMARC" removed when "--insert" is selected)

Change History (7)

comment:1 Changed 15 months ago by skaplun

  • Component changed from BibUpload to BatchUploader

comment:2 Changed 14 months ago by simko

  • Component changed from BatchUploader to BibEdit
  • Owner set to jmartinm

comment:3 Changed 11 months ago by jmartinm

  • Owner changed from jmartinm to jcaffaro
  • Status changed from new to in_review

Commits

7949e5658fe0713201501f9f0742795ee27d1c02
545d9bf3de05ffbc3e16ffab057c3c0127aa2a4a

in branch jmartinm/rebase-master-batchuploader-multiedit

address this problem. Could you review the code?

comment:4 Changed 11 months ago by jcaffaro

  • Milestone set to v1.2

comment:5 Changed 11 months ago by jcaffaro

  • Milestone v1.2 deleted

comment:6 Changed 11 months ago by jcaffaro

  • Status changed from in_review to in_merge

Reviewed code and tested successfully (as far as this ticket is concerned, i.e. not including other commits in the branch).

Note the following line in commit 16612d9:

+>>>>>>> e0af3b3... BatchUploader: dynamic size for input of email logs to

You can also maybe add the directive Closes #1023 in the commit log.

comment:7 Changed 11 months ago by simko

  • Owner changed from jcaffaro to simko
  • Status changed from in_merge to in_review
Note: See TracTickets for help on using tickets.